Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increasing node memory to be able to build the store-sync package #2802

Merged
merged 1 commit into from
May 10, 2024
Merged

increasing node memory to be able to build the store-sync package #2802

merged 1 commit into from
May 10, 2024

Conversation

joergkiesewetter
Copy link
Contributor

@joergkiesewetter joergkiesewetter commented May 8, 2024 •
edited by holic
Loading

fixes #2801

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: b6d32a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic
holic approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this nicely mirrors

mud/.github/workflows/build.yml

Lines 9 to 10 in 0ae9189

env:
NODE_OPTIONS: "--max-old-space-size=4096"
from #2772

@holic
Copy link
Member

holic commented May 8, 2024 •
edited
Loading

I just noticed this is running on an old fork of this repo with some changes that diverge from main, which is causing CI to fail. Mind rebasing your branch on latest main?

@joergkiesewetter
Copy link
Contributor Author

This PR is targeting branch 'historical_indexer', because I need the change in this branch. Should I make a new one for main branch and you merge main into historical_indexer?

@holic
Copy link
Member

holic commented May 10, 2024

oh sorry! I missed that detail in the description in the issue

what are you using the historical indexer for? that'd help me figure out if we should catch it up to main or not

@holic holic merged commit 31e0a4b into latticexyz:historical-indexer May 10, 2024
0 of 14 checks passed
@holic
Copy link
Member

holic commented May 10, 2024

this would be a welcome change in main as well if you're up for it!

@joergkiesewetter
Copy link
Contributor Author

oh sorry! I missed that detail in the description in the issue

what are you using the historical indexer for? that'd help me figure out if we should catch it up to main or not

it's used for the skystrife analytics dashboard by world explorers https://skystrife.worlds.online/

joergkiesewetter added a commit to joergkiesewetter/mud that referenced this pull request May 10, 2024
@joergkiesewetter
increasing node memory to be able to build the store-sync package (la…
04e3126 
…tticexyz#2802)

(cherry picked from commit 31e0a4b)
@joergkiesewetter joergkiesewetter mentioned this pull request May 10, 2024
Merged
@joergkiesewetter
Copy link
Contributor Author

I created a new pull request for main #2810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

@yonadaa yonadaa Awaiting requested review from yonadaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joergkiesewetter @holic